Add leave team button #11757
Merged
Add leave team button #11757
+107
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Dec 20, 2024
resources/views/teams/show.blade.php
Outdated
Comment on lines
18
to
21
| $buttons = new Ds\Set(); | ||
| if ($currentUser !== null && $currentUser->team?->getKey() === $team->getKey() && $currentUser->getKey() !== $team->leader_id) { | ||
| $buttons->add('part'); | ||
| } |
There was a problem hiding this comment.
Are there more buttons coming 👀
notbakaneko
reviewed
Dec 20, 2024
resources/views/teams/show.blade.php
Outdated
| method="POST" | ||
| > | ||
| <button class="team-action-button team-action-button--part"> | ||
| {{ osu_trans('teams.show.bar.part') }} |
|
sec, I think it's more convenient to just add an OsuAuthorize check |
notbakaneko
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart of the message that needs fixing, I wonder if the route should have team id in it... (there's also question of if it's worth adding an OsuAuthorize check for this)